devpkg: fix empty patch mode #2278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a case where an empty patch mode wouldn't default to "auto". This was causing Devbox to skip patching when it should not have. Got rid of the sync.OnceValue function for determining if a package needs to be patched. This was originally done to avoid a call to nix.System(), but that call doesn't happen anymore.
gcurtis
force-pushed
the
gcurtis/fix-empty-patch-mode
branch
from
af7736a to
e99a5de
Compare
savil
approved these changes
Sep 17, 2024
mikeland73
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a case where an empty patch mode wouldn't default to "auto". This was causing Devbox to skip patching when it should not have.
Got rid of the sync.OnceValue function for determining if a package needs to be patched. This was originally done to avoid a call to nix.System(), but that call doesn't happen anymore.